Conversation
What was broken Marathon Match final scores stayed hidden in Community App while the review phase was still open, even after Review API had stored the system-test final scores. Root cause The MM submission views treated review completion as a prerequisite for rendering final scores, so open-review challenges forced the final-score fields to `N/A` or `-` despite having `finalScore` data. What was changed Removed the review-complete gate from the MM submissions table and submission history rows. Updated My Submissions and the submission details modal to surface `finalScore` as soon as it exists, while still preferring `initialScore` over stale provisional-score values. Any added/updated tests Updated the My Submissions score regression test to verify final scores remain visible before the review phase closes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Marathon Match final scores stayed hidden in Community App while the review phase was still open, even after Review API had stored the system-test final scores.
Root cause
The MM submission views treated review completion as a prerequisite for rendering final scores, so open-review challenges forced the final-score fields to
N/Aor-despite havingfinalScoredata.What was changed
Removed the review-complete gate from the MM submissions table and submission history rows.
Updated My Submissions and the submission details modal to surface
finalScoreas soon as it exists, while still preferringinitialScoreover stale provisional-score values.Any added/updated tests
Updated the My Submissions score regression test to verify final scores remain visible before the review phase closes.