Conversation
What was broken F2F draft challenges could reach the launch flow with manual reviewer rows that no longer had a persisted review opportunity type, which left the work app depending on a visual-only dropdown default and could block launch validation until the user reselected Iterative Review manually. Root cause The recent manual reviewer review-type restoration only covered the form model and UI rendering. The work challenge service still stripped reviewer type values from patch payloads, and legacy reviewer rows missing the field were never backfilled into real form state. What was changed Manual reviewer rows now backfill a concrete review type from the matching default reviewer configuration, with an Iterative Review fallback for iterative-review phases and Regular Review for other legacy rows. The work challenge serializer now preserves reviewer type values when patching manual reviewer configurations so saved drafts and launch requests stay aligned with work-manager behavior. Updated the challenge editor README to document the legacy review-type backfill behavior. Any added/updated tests Added a HumanReviewTab regression that verifies iterative-review rows missing a stored type are backfilled into form state. Added a challenges.service regression that verifies patchChallenge keeps reviewer type in the serialized payload. Ran the full platform-ui test suite plus the repo-required lint and build validation.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
F2F draft challenges could reach the launch flow with manual reviewer rows that no longer had a persisted review opportunity type, which left the work app depending on a visual-only dropdown default and could block launch validation until the user reselected Iterative Review manually.
Root cause
The recent manual reviewer review-type restoration only covered the form model and UI rendering. The work challenge service still stripped reviewer type values from patch payloads, and legacy reviewer rows missing the field were never backfilled into real form state.
What was changed
Manual reviewer rows now backfill a concrete review type from the matching default reviewer configuration, with an Iterative Review fallback for iterative-review phases and Regular Review for other legacy rows.
The work challenge serializer now preserves reviewer type values when patching manual reviewer configurations so saved drafts and launch requests stay aligned with work-manager behavior.
Updated the challenge editor README to document the legacy review-type backfill behavior.
Any added/updated tests
Added a HumanReviewTab regression that verifies iterative-review rows missing a stored type are backfilled into form state.
Added a challenges.service regression that verifies patchChallenge keeps reviewer type in the serialized payload.
Ran the full platform-ui test suite plus the repo-required lint and build validation.