Conversation
What was broken Work stream, work, and work item read routes could still reject legitimate Projects API users before or during permission evaluation. The work-layer controllers only admitted a narrow role subset, and the named work-view permissions still excluded manager-tier legacy project-view access. Root cause (if identifiable) The earlier PM-3764 follow-ups restored legacy read parity for projects, members, invites, and attachments, but the work-layer endpoints were still using narrower auth rules than the legacy v5 projectView policy. What was changed Broadened the work-layer coarse role gate to accept all known human roles so project-member access reaches PermissionGuard. Updated work-layer view permissions to allow manager-tier legacy project-view access and machine connect_project_admin scope, and aligned the Swagger/docs output with that behavior. Documented the remaining PM-3764 work-layer read parity in the permissions docs. Any added/updated tests Added a TokenRolesGuard regression for Topcoder User tokens on work-layer routes. Expanded PermissionService regression coverage for manager-tier work-layer reads and machine connect_project_admin scope. Validated with pnpm lint, targeted auth/work regressions, and pnpm build. Full pnpm test still has the existing unrelated metadata event-bus failures on the current dev baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Work stream, work, and work item read routes could still reject legitimate Projects API users before or during permission evaluation. The work-layer controllers only admitted a narrow role subset, and the named work-view permissions still excluded manager-tier legacy project-view access.
Root cause (if identifiable)
The earlier PM-3764 follow-ups restored legacy read parity for projects, members, invites, and attachments, but the work-layer endpoints were still using narrower auth rules than the legacy v5 projectView policy.
What was changed
Broadened the work-layer coarse role gate to accept all known human roles so project-member access reaches PermissionGuard.
Updated work-layer view permissions to allow manager-tier legacy project-view access and machine connect_project_admin scope, and aligned the Swagger/docs output with that behavior.
Documented the remaining PM-3764 work-layer read parity in the permissions docs.
Any added/updated tests
Added a TokenRolesGuard regression for Topcoder User tokens on work-layer routes.
Expanded PermissionService regression coverage for manager-tier work-layer reads and machine connect_project_admin scope.
Validated with pnpm lint, targeted auth/work regressions, and pnpm build.
Full pnpm test still has the existing unrelated metadata event-bus failures on the current dev baseline.