Prod - April release by jmgasper · Pull Request #162 · topcoder-platform/tc-finance-api

jmgasper · 2026-04-13T04:07:06Z

https://topcoder.atlassian.net/browse/PM-4429
https://topcoder.atlassian.net/browse/PM-4623
https://topcoder.atlassian.net/browse/PM-4657
https://topcoder.atlassian.net/browse/PM-4773
https://topcoder.atlassian.net/browse/PM-4822

…is taas

…loop

What was broken PM-4623's wallet-admin engagement payment flow was already implemented in the current dev lineage, but tc-finance-api validation could not complete because winnings creation no longer satisfied Prisma's JSON input typing after the hours-worked attribute support was added. Root cause The winnings attribute helper used broad object/null typing, while the create path now needs Prisma-compatible JSON input values and a typed payroll attribute lookup. What was changed Updated the winnings attribute normalization helper to return Prisma-compatible JSON input, return undefined instead of null when no attributes are present, and narrowed the create-path attribute handling so the hours-worked and payroll lookups remain type-safe without changing runtime behavior. Any added/updated tests No test files were changed. Re-ran the existing platform-ui and tc-finance-api test suites, plus the required lint/build commands.

PM-4429 - use metadata for taas payments

PM-4623: validate wallet-admin engagement payment details flow

What was broken Wallet-admin payment details only enriched engagement payments when the winning could be resolved through the assignment context endpoint. Payments whose `external_id` stored an engagement id instead of an assignment id showed work-log data but missed the engagement details needed to build the Work Manager assignee link and assignment context section. Root cause The admin payment-details flow treated the stored identifier as an assignment id and stopped after the assignment-context lookup failed, even though some winnings only retained the parent engagement id. Numeric assignment ids in winning attributes also needed to be normalized before lookup. What was changed Added typed engagement API models and a direct engagement lookup helper in the Topcoder engagements client. Updated the admin payment-details service to normalize numeric assignment ids, try the assignment-context endpoint first, and then fall back to loading the engagement and matching the correct assignment by assignment id or winner id when needed. Any added/updated tests Extended the admin service spec with regressions for the engagement-id fallback path and for numeric assignment ids stored in winning attributes.

…tering PM-4657 - Role‑Based Access Control in Wallet Admin

PM-4623: fall back to engagement lookup for payment details

PM-4773 - topgear payments

…o PM-4789_payment-migrations

What was broken The wallet-admin payments CSV download still did not include the Payment Creator column after the earlier fix. QA could see the creator in payment details, but the exported report remained unchanged. Root cause The previous fix only populated payment creator data for the payment-details endpoint. The CSV export path in `admin.controller.ts` assembled its own columns and rows and never added the creator field or resolved creator handles for engagement payments. What was changed Updated the winnings export controller to collect engagement payment creator member IDs, resolve their handles, and emit a Payment Creator column before Billing Account. The export leaves that column blank for non-engagement payment types. Any added/updated tests Added `src/api/admin/admin.controller.spec.ts` to verify the CSV header includes Payment Creator and that only engagement payment rows populate it.

PM-4822: add Payment Creator to wallet export CSV

…ions PM-4789 payment migrations

Copilot

Pull request overview

This PR packages the April production release work across finance winnings, access control, and Topcoder engagement enrichment, including new winnings categories and supporting Prisma migrations/client regeneration.

Changes:

Added TAAS/TOPGEAR winnings categories (DTO + Prisma schema) with backfill migrations, and mapped payment_type challenge metadata to these categories.
Introduced the Wipro TaaS Admin role and access-control provider, including controller role wiring and tests.
Added an admin “payment details” endpoint that enriches engagement payments with engagement/assignment context and exposes work-log + creator-handle info for wallet-admin UI.

Reviewed changes

Copilot reviewed 37 out of 48 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/shared/topcoder/topcoder.module.ts	Registers/exports the new engagements Topcoder client service.
src/shared/topcoder/engagements.service.ts	Adds Topcoder engagements API client for engagement + assignment context lookups.
src/shared/access-control/wipro-taas-admin.provider.ts	New role access provider that scopes/validates access to TAAS payments.
src/shared/access-control/wipro-taas-admin.provider.spec.ts	Unit tests for TAAS admin provider behavior.
src/shared/access-control/index.ts	Exports the new TAAS admin provider.
src/shared/access-control/access-control.service.ts	Extends “Payment Admin overrides scoped approvers” logic to include Wipro TaaS Admin.
src/shared/access-control/access-control.service.spec.ts	Tests for Wipro TaaS Admin filter application and override behavior.
src/shared/access-control/access-control.module.ts	Registers the new access provider in the module registrar.
src/dto/winning.dto.ts	Adds TAAS/TOPGEAR categories and `createdBy` field to winning DTO.
src/core/auth/auth.constants.ts	Introduces `Role.WiproTaasAdmin`.
src/api/winnings/winnings.service.ts	Tightens attribute typing/normalization and payroll flag extraction.
src/api/wallet/wallet.controller.ts	Adds Wipro TaaS Admin role access to wallet endpoint.
src/api/repository/winnings.repo.ts	Populates `createdBy` from payment creator when available.
src/api/challenges/challenges.service.ts	Maps `payment_type` metadata to TAAS/TOPGEAR categories when generating winnings.
src/api/challenges/challenges.service.spec.ts	Tests for TAAS/TOPGEAR metadata mapping.
src/api/admin/dto/payment-details.dto.ts	New DTOs for wallet-admin payment details payload.
src/api/admin/admin.service.ts	Adds `getWinningPaymentDetails` and engagement enrichment helpers.
src/api/admin/admin.service.spec.ts	Unit tests for new payment details enrichment behavior and fallbacks.
src/api/admin/admin.controller.ts	Adds payment-details endpoint + export CSV “Payment Creator” column + role updates.
src/api/admin/admin.controller.spec.ts	Tests for export CSV including Payment Creator column only for engagement payments.
prisma/schema.prisma	Adds TAAS/TOPGEAR winnings category enum values.
prisma/migrations/20260331120000_add_taas_payment_category/migration.sql	Adds TAAS_PAYMENT enum value.
prisma/migrations/20260407120000_add_topgear_payment_category/migration.sql	Adds TOPGEAR_PAYMENT enum value.
prisma/migrations/20260408120000_backfill_taas_category_from_metadata/migration.sql	Backfills TAAS category based on challenge metadata.
prisma/migrations/20260408130000_backfill_topgear_category_from_billing_account/migration.sql	Backfills TOPGEAR category based on billing accounts.
packages/finance-prisma-client/wasm.js	Regenerated Prisma client artifact reflecting schema/category updates.
packages/finance-prisma-client/wasm-worker-loader.mjs	Regenerated Prisma client artifact (adds biome ignore).
packages/finance-prisma-client/wasm-edge-light-loader.mjs	Regenerated Prisma client artifact (adds biome ignore).
packages/finance-prisma-client/schema.prisma	Regenerated packaged Prisma schema with new enum values/index.
packages/finance-prisma-client/runtime/library.js	Regenerated Prisma runtime artifact (adds biome ignore + version bump).
packages/finance-prisma-client/runtime/index-browser.js	Regenerated Prisma runtime artifact (adds biome ignore).
packages/finance-prisma-client/query_engine_bg.js	Regenerated Prisma engine JS glue artifact.
packages/finance-prisma-client/package.json	Prisma client package regen/version bump.
packages/finance-prisma-client/index.d.ts	Regenerated Prisma typings for new enum values/version.
packages/finance-prisma-client/index-browser.js	Regenerated Prisma browser entry artifact (adds biome ignore + enum update).
packages/finance-prisma-client/default.js	Regenerated Prisma entry artifact (adds biome ignore).
packages/finance-prisma-client/client.js	Regenerated Prisma entry artifact (adds biome ignore).
.circleci/config.yml	Updates CircleCI branch filter for the prod workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-14T08:48:22Z

    "previewFeatures": [],
-    "sourceFilePath": "/Users/hentrymartin/development/tc-finance-api/prisma/schema.prisma",
+    "sourceFilePath": "/home/vasea/work/topcoder/tc-finance-api/prisma/schema.prisma",
    "isCustomOutput": true


This generated Prisma client file embeds an absolute local filesystem path in sourceFilePath. This causes noisy diffs between environments and can leak workstation paths into the repo. Consider making the generation output deterministic or stripping/sanitizing these fields post-generate if this package is committed.

Copilot · 2026-04-14T08:48:23Z

+    const paymentCreatorHandle = await this.getPaymentCreatorHandle(
+      winning.created_by,
+    );


paymentCreatorHandle is derived from winning.created_by, but for payments the creator is typically stored on the related payment.created_by (and this PR already introduces createdBy derived from payment?.[0]?.created_by in WinningsRepository). As-is, the payment details endpoint can show the wrong creator when a payment record was created/updated by someone other than the winning row creator. Consider fetching the latest payment for the winning and prefer its created_by (falling back to winnings.created_by if no payment exists).

Copilot · 2026-04-14T08:48:23Z

+      } catch (error) {
+        this.logger.warn(
+          `Failed to enrich winning ${winningsId} with assignment context`,
+          error instanceof Error ? error.message : error,
+        );
+      }


getAssignmentContextById failures are treated as warnings, but the method intentionally calls the assignment-context endpoint even when external_id may contain an engagement id (see the spec that expects this failure and fallback). This will generate warning-level log noise in normal operation. Consider either detecting engagement vs assignment ids (and skipping the context call when it’s clearly an engagement id), or downgrading expected 404/validation failures to debug while keeping unexpected errors as warn/error.

Copilot · 2026-04-14T08:48:23Z

    "output": {
-      "value": "/Users/hentrymartin/development/tc-finance-api/packages/finance-prisma-client",
+      "value": "/home/vasea/work/topcoder/tc-finance-api/packages/finance-prisma-client",
      "fromEnvVar": null


This generated Prisma client file embeds an absolute local filesystem path in the generator output.value. This causes noisy diffs between environments and can leak workstation paths into the repo. If the generated client must be committed, consider making the generation output deterministic or stripping/sanitizing these fields post-generate.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 7 additional findings.

jmgasper and others added 21 commits March 31, 2026 17:16

Return engagement details when returning payment info, for wallet-admin

fcdaa8a

PM-4429 - use metadata from incoming payment to determine if payment …

a53e51a

…is taas

PM-4429 - Move getDefaultWinnerCategory call outside the winners map …

cbd2c7b

…loop

Merge pull request #151 from topcoder-platform/PM-4429_tass-payments

30cd3ad

PM-4429 - use metadata for taas payments

Merge pull request #152 from topcoder-platform/PM-4623

7997cc6

PM-4623: validate wallet-admin engagement payment details flow

PM-4657 - Role‑Based Access Control in Wallet Admin

30dc0c6

pr feedback

c017896

Merge pull request #154 from topcoder-platform/PM-4657_taas-admin-fil…

7d07f77

…tering PM-4657 - Role‑Based Access Control in Wallet Admin

Merge pull request #153 from topcoder-platform/PM-4623-1

4262056

PM-4623: fall back to engagement lookup for payment details

PM-4773 - topgear payments

aaf73fa

Merge pull request #156 from topcoder-platform/PM-4773_topgear-payments

b9610b3

PM-4773 - topgear payments

Migration to ensure TAAS payments

f6a2be8

deploy

6bddfd9

PM-4789 categorize topgear payments

3e2e885

Merge branch 'dev' of github.com:topcoder-platform/tc-finance-api int…

79c40a2

…o PM-4789_payment-migrations

Additional fields for wallet-admin to show expanded engagement details

ef5813c

Merge pull request #158 from topcoder-platform/PM-4822

020fdc2

PM-4822: add Payment Creator to wallet export CSV

Merge pull request #157 from topcoder-platform/PM-4789_payment-migrat…

c31b6f4

…ions PM-4789 payment migrations

kkartunov requested review from Copilot and kkartunov April 14, 2026 08:42

Copilot started reviewing on behalf of kkartunov April 14, 2026 08:42 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

devin-ai-integration bot reviewed Apr 14, 2026

View reviewed changes

kkartunov approved these changes Apr 14, 2026

View reviewed changes

jmgasper merged commit fd8169f into master Apr 15, 2026
10 of 12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prod - April release#162

Prod - April release#162
jmgasper merged 21 commits intomasterfrom
dev

jmgasper commented Apr 13, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

Copilot AI Apr 14, 2026

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jmgasper commented Apr 13, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmgasper commented Apr 13, 2026 •

edited by devin-ai-integration bot

Loading