PM-4685: remove submission limit section

src/components/ChallengeEditor/TextEditor-Field/index.js

@@ -5,7 +5,6 @@ import SkillsField from '../SkillsField'
 import FinalDeliverablesField from '../FinalDeliverables-Field'
 import StockArtsField from '../StockArts-Field'
 import SubmssionVisibility from '../SubmissionVisibility-Field'
-import MaximumSubmissionsField from '../MaximumSubmissions-Field'
 import { CHALLENGE_TRACKS } from '../../../config/constants'
 import styles from './TextEditor-Field.module.scss'
 import PropTypes from 'prop-types'
@@ -123,11 +122,6 @@ class TextEditorField extends Component {
               onUpdateCheckbox={onUpdateMetadata}
               readOnly={readOnly}
             />
-            <MaximumSubmissionsField
-              challenge={challenge}
-              onUpdateMetadata={onUpdateMetadata}
-              readOnly={readOnly}
-            />
           </React.Fragment>
         )}
       </div>

src/components/ChallengeEditor/TextEditor-Field/index.test.js

@@ -0,0 +1,75 @@
+/* global describe, it, expect, beforeEach, afterEach, jest */
+
+import React from 'react'
+import ReactDOM from 'react-dom'
+import { act } from 'react-dom/test-utils'
+import TextEditorField from './index'
+import { CHALLENGE_TRACKS } from '../../../config/constants'
+
+jest.mock('../SpecialChallengeField', () => () => null)
+jest.mock('../TagsField', () => () => null)
+jest.mock('../SkillsField', () => () => null)
+jest.mock('../FinalDeliverables-Field', () => () => null)
+jest.mock('../StockArts-Field', () => () => null)
+jest.mock('../SubmissionVisibility-Field', () => () => null)
+jest.mock('../Description-Field', () => () => null)
+jest.mock('../ChallengeReviewer-Field', () => () => null)
+jest.mock('../../Buttons', () => ({
+  PrimaryButton: () => null
+}))
+
+describe('TextEditorField', () => {
+  let container
+
+  const renderComponent = (props = {}) => {
+    act(() => {
+      ReactDOM.render(
+        <TextEditorField
+          challenge={{ trackId: CHALLENGE_TRACKS.DESIGN, metadata: [] }}
+          shouldShowPrivateDescription={false}
+          {...props}
+        />,
+        container
+      )
+    })
+  }
+
+  beforeEach(() => {
+    container = document.createElement('div')
+    document.body.appendChild(container)
+  })
+
+  afterEach(() => {
+    ReactDOM.unmountComponentAtNode(container)
+    container.remove()
+    container = null
+    jest.clearAllMocks()
+  })
+
+  it('does not render submission limit controls for design challenges while editing', () => {
+    renderComponent()
+
+    expect(container.textContent).not.toContain('Maximum Number of Submissions')
+    expect(container.textContent).not.toContain('Unlimited')
+    expect(container.querySelector('#limit')).toBeNull()
+    expect(container.querySelector('#count')).toBeNull()
+  })
+
+  it('does not render a submission limit summary for design challenges in read-only mode', () => {
+    renderComponent({
+      readOnly: true,
+      challenge: {
+        trackId: CHALLENGE_TRACKS.DESIGN,
+        metadata: [
+          {
+            name: 'submissionLimit',
+            value: '{"unlimited":"true","limit":"false","count":""}'
+          }
+        ]
+      }
+    })
+
+    expect(container.textContent).not.toContain('Maximum Number of Submissions')
+    expect(container.textContent).not.toContain('Unlimited')
+  })
+})

src/components/ChallengeEditor/index.js

@@ -622,27 +622,8 @@ class ChallengeEditor extends Component {
     if (!existingMetadata) {
       existingMetadata = { name }
       newChallenge.metadata.push(existingMetadata)
-      if (name === 'submissionLimit') {
-        existingMetadata.value = '{}'
-      }
     }
-    if (existingMetadata.name === 'submissionLimit') {
-      const submissionLimit = JSON.parse(existingMetadata.value)
-      _.forOwn(submissionLimit, (value, key) => {
-        if (value === 'true') {
-          submissionLimit[key] = 'false'
-        }
-      })
-      submissionLimit[path] = `${value}`
-      if (path === 'count') {
-        submissionLimit.limit = 'true'
-        submissionLimit.unlimited = 'false'
-      } else if (path === 'unlimited' && value) {
-        submissionLimit.limit = 'false'
-        submissionLimit.count = ''
-      }
-      existingMetadata.value = JSON.stringify(submissionLimit)
-    } else if (existingMetadata.name === 'show_data_dashboard') {
+    if (existingMetadata.name === 'show_data_dashboard') {
       existingMetadata.value = Boolean(value)
     } else {
       existingMetadata.value = `${value}`