Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Separated component to improve React key usage by replacing array indices with child element keys for better rendering stability and performance.
- Changes the React
keyfrom array index tochild.keyin the mapped children - Improves rendering consistency during updates like insertion, deletion, or reordering
- Follows React best practices by avoiding array index keys
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 1093 1093
Branches 324 324
=========================================
Hits 1093 1093 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the
Separatedcomponent by changing the Reactkeyused in the mapped children from the array index to the child element’s ownkey.Using array indices as keys in React lists is considered an anti-pattern because it can cause issues with component state, performance, and rendering consistency during updates such as insertion, deletion, or reordering.
By leveraging the unique
keyproperty provided by React elements viaChildren.toArray(), this change enhances rendering stability and avoids unnecessary re-renders or UI glitches.This results in more predictable behavior, better performance, and easier maintenance for components using
Separated.Checklist
yarn run fixto format and lint the code and docsyarn run test:coverageto confirm coverage completeness