Catch Throwable in LogcatWriter, for unit tests#476
Catch Throwable in LogcatWriter, for unit tests#476angusholder wants to merge 1 commit intotouchlab:mainfrom
Conversation
faogustavo
left a comment
There was a problem hiding this comment.
Thanks for the fix. I'm approving it and running the tests.
I'd only like to encourage the use of the 'TestLogWriter' in test cases, which is the appropriate writer for tests. But that's a minor detail, the fix is still relevant :)
|
Thanks! TestLogWriter looks useful, although here I wasn't interested in testing the log output - all this code under test uses the default global I don't know of any way to configure the logger globally before the junit4 tests run, short of adding a test rule to every test, so that's why it's running with the default writer. I don't inject my loggers in most code currently, because I'm switching from Timber which doesn't really give you that option |
To address #475
Is it okay with you to broaden the catch to Throwable, or would you rather I add a second catch block for just UnsatisfiedLinkError?