[ENH] Return to float16 for streamline data#196
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce streamline storage size by returning to float16 for streamline positions (especially for TRX outputs) and adds safeguards/normalization to keep downstream DIPY operations working with float32.
Changes:
- Updates cuslines compression settings in probabilistic/PTT tracking to emit
float16positions. - Adjusts TRX dtype handling in tractography/segmentation tasks (positions/offsets).
- Forces resampling inputs to
float32viaStreamlinesnormalization before calling DIPY resampling utilities.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
setup.cfg |
Updates gpu extra cuslines pin (currently creates a resolver conflict with core pin). |
AFQ/tractography/tractography.py |
Sets cuslines tracker compression parameters to use float16 positions. |
AFQ/tasks/tractography.py |
Changes TRX dtype_dict (offsets dtype) for TRX writing from lazy tractograms. |
AFQ/tasks/segmentation.py |
Switches TRX streamline positions to float16 and adjusts per-bundle export behavior. |
AFQ/recognition/utils.py |
Normalizes streamlines to float32 before resampling via DIPY. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arokem
reviewed
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not linearizing because it only decreased disk size by around 30% for 0.1mm tolerance