549 injected contentscript div may affect page content #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #549, fix #529
Changes
#549 - the problem is root container with popup content is in page flow. The problem is fixed with set
position: absolute#529 - the problem is site https://www.gnu.org/software/findutils/ have styles on
bodythat is align body by center and limit its size. The root container is nested insidebody, so it shifts coordinates too. As result, root node coordinate is not0/0, but instead250/0, so when popup coordinates is set as100/0, it actually renders on350/0.The problem is fixed with substraction a root container coordinates of target coordinates.