Skip to content

(Chore): Support overriding codeowners type#1053

Merged
trunk-io[bot] merged 4 commits intomainfrom
tyler/codeowners-type
Mar 23, 2026
Merged

(Chore): Support overriding codeowners type#1053
trunk-io[bot] merged 4 commits intomainfrom
tyler/codeowners-type

Conversation

@TylerJang27
Copy link
Copy Markdown
Collaborator

--codeowners-type or TRUNK_CODEOWNERS_TYPE. Formerly we were trying GitLab and falling back to GitHub format. Some CODEOWNERS files are "cross-compatible" to the point where we weren't falling back

I verified on the customer's CODEOWNERS file and the proper files were parsed

Related:

@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Mar 23, 2026

😎 Merged successfully - details.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 71.59091% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.85%. Comparing base (bddc7a9) to head (2bf9a6a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
codeowners/src/main.rs 0.00% 12 Missing ⚠️
cli/src/upload_command.rs 16.66% 5 Missing ⚠️
test_report/src/report.rs 42.85% 4 Missing ⚠️
codeowners/src/codeowners.rs 92.85% 3 Missing ⚠️
cli/src/validate_command.rs 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
+ Coverage   81.54%   81.85%   +0.31%     
==========================================
  Files          69       69              
  Lines       14691    14790      +99     
==========================================
+ Hits        11980    12107     +127     
+ Misses       2711     2683      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-staging-io
Copy link
Copy Markdown

trunk-staging-io bot commented Mar 23, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Mar 23, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link
Copy Markdown
Member

@dfrankland dfrankland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't improve ingestion though, does it?

@trunk-io trunk-io bot merged commit b6cde87 into main Mar 23, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants