Skip to content

(Chore): Add -vv logs for junit validation errors#1054

Merged
trunk-io[bot] merged 1 commit intomainfrom
tyler/trace-logs-for-invalidations
Mar 23, 2026
Merged

(Chore): Add -vv logs for junit validation errors#1054
trunk-io[bot] merged 1 commit intomainfrom
tyler/trace-logs-for-invalidations

Conversation

@TylerJang27
Copy link
Copy Markdown
Collaborator

Right now the validate command often doesn't have a great CTA to resolve the issues, particularly when the test case names/file names are too short.

I don't want to undertake redesigning the UX and output format of the validate command rn, and customer asks for assistance with fixing defects is pretty rare. So for now, with this change, just run with -vv to show all the defects and the information we have about them.

2026-03-23T20:03:10.317736Z TRACE context::junit::validator: junit testcase validation issue issue_message=test case or parent has old (> 24 hour(s)) timestamp test_suite_name=TestSuite test_case_name=TestCase test_case_classname=Some("TestClass") test_case_file_or_filepath=TestFile test_case_time=Some(0.55)

@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Mar 23, 2026

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@trunk-staging-io
Copy link
Copy Markdown

trunk-staging-io bot commented Mar 23, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.83%. Comparing base (bddc7a9) to head (ca8cbb7).

Files with missing lines Patch % Lines
context/src/junit/validator.rs 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
+ Coverage   81.54%   81.83%   +0.29%     
==========================================
  Files          69       69              
  Lines       14691    14718      +27     
==========================================
+ Hits        11980    12045      +65     
+ Misses       2711     2673      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TylerJang27 TylerJang27 requested a review from dfrankland March 23, 2026 20:28
@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Mar 23, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@dfrankland
Copy link
Copy Markdown
Member

-✌️✌️

@TylerJang27 TylerJang27 requested a review from max-trunk March 23, 2026 20:39
@trunk-io trunk-io bot merged commit ce2568e into main Mar 23, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants