Conversation
The GitHub Actions CI provider page told users to store secrets as TRUNK_ORG_URL_SLUG and TRUNK_API_TOKEN, but the code examples on the same page reference secrets.TRUNK_ORG_SLUG and secrets.TRUNK_TOKEN. A user following the instructions step by step would save the secret under one name and reference it under another. Changed to TRUNK_ORG_SLUG and TRUNK_TOKEN to match the code examples on the page and every other CI provider doc. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Merging to
|
|
Claude finished @samgutentag's task in 54s —— View job PR Review
The Fix (line 38) ✅The change is correct. The setup instructions now tell users to store secrets as Remaining Inconsistencies
|
|
Claude finished @samgutentag's task in 1m 3s —— View job PR Review
Blocking Issue: Unresolved Merge Conflict ❌The file contains unresolved git conflict markers at line 38 of The merge conflict was committed to the branch without being resolved. The The correct resolution is to keep the PR branch version ( Other ObservationsDuplicate intro paragraph (pre-existing, not introduced by this PR): Lines 7 and 11 are nearly identical:
One of these should be removed. Quarantining/token references: The rest of the file consistently uses The core intent of this PR (fixing the |
Summary
Audited all org slug terminology across the docs for consistency. Searched every
.mdfile for:TRUNK_ORG_SLUG,TRUNK_ORG_URL_SLUG,org-url-slug,org-slug, and "organization slug".What was fixed
flaky-tests/get-started/ci-providers/github-actions.mdline 38 — The setup instructions told users to store GitHub secrets asTRUNK_ORG_URL_SLUGandTRUNK_API_TOKEN, but the code examples on the same page referencesecrets.TRUNK_ORG_SLUGandsecrets.TRUNK_TOKEN. A user following the instructions step by step would save the secret under one name and reference it under another. Changed toTRUNK_ORG_SLUGandTRUNK_TOKENto match the code examples and every other CI provider doc.What was confirmed correct
--org-url-slugconsistently (matches the actual binary flag).TRUNK_ORG_URL_SLUG: Used correctly in RSpec plugin examples where the CLI reads from environment (e.g.,TRUNK_ORG_URL_SLUG=$TRUNK_ORG_SLUG). These pass an arbitrary CI secret name into the real env var the CLI reads — correct pattern.org-slug:(matches action.yaml).<TRUNK_ORG_SLUG>used consistently as a human-readable template token in non-Action CLI examples.TRUNK_ORG_SLUG— no issues found.TRUNK_ORG_URL_SLUG=<TRUNK_ORG_URL_SLUG>(setting the real env var directly with a placeholder value).Open questions
None — the only issue found was the GitHub Actions page mismatch, which is now fixed.
🤖 Generated with Claude Code