Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds FreeBSD client support to the agent deployment system by implementing platform-specific service management alongside the existing Linux/systemd support.
Changes:
- Added FreeBSD rc service support with kernel-based branching in deploy, teardown, and update operations
- Changed file ownership specification from "root:root" to "0:0" for cross-platform compatibility
- Removed the FreeBSD blocking error in machine.go to enable FreeBSD deployments
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/agent/update.go | Added kernel switch to restart services using either systemctl (Linux) or service command (FreeBSD) |
| internal/agent/teardown.go | Refactored into kernel-specific helper methods for systemd and rc service cleanup, updated signature to accept MachineInfo |
| internal/agent/machine.go | Enabled FreeBSD support by removing the blocking error and properly assigning arch variable |
| internal/agent/deploy.go | Added FreeBSD rc service deployment, changed ownership to numeric IDs, and added kernel-based service enablement |
| internal/agent/assets/alloy.rc | New FreeBSD rc script for alloy service with proper daemon configuration |
| internal/agent/agent_test.go | Updated test expectations to reflect changes in execution flow with kernel-agnostic dry-run mode |
| internal/agent/agent.go | Updated teardownAgent call to pass MachineInfo parameter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.