fix: declare format-si-unit and zod as runtime dependencies#633
Open
yasdhf wants to merge 1 commit into
Open
Conversation
This was referenced Jul 1, 2026
The published dist/index.mjs externally imports format-si-unit and zod, but package.json declares no dependencies at all — both are only devDependencies. A clean install of circuit-json alone cannot be imported: Cannot find package 'format-si-unit' from '.../circuit-json/dist/index.mjs' Consumers only survive when another package happens to hoist these, and strict/isolated layouts (pnpm) break regardless. Fix: declare both packages in dependencies.
yasdhf
force-pushed
the
fix/declare-runtime-dependencies
branch
from
fcb7908 to
143bb8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A clean install of
circuit-jsonalone cannot be imported:The published
dist/index.mjsexternally imports exactly two packages —format-si-unitandzod— andpackage.jsondeclares no dependencies at all (both are devDependencies only). Consumers survive only when another package hoists these; strict/isolated layouts (pnpm) break regardless.Verified on
circuit-json@0.0.443: clean dir,bun add circuit-json,import * as cj from "circuit-json"→ the error above.Fix
Declare
format-si-unitandzodindependencies(moved out of devDependencies), lockfile synced.