Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds a new (currently skipped) regression fixture for a specific SchematicTrace pipeline case involving a J2 ↔ U1 9-pin one-to-one mapping, preserving the failing scenario without making CI red.
Changes:
- Added
SchematicTracePipelineSolver_repro04fixture describing the J2/U1 9-pin layout and direct connections. - Marked the new repro test as skipped while still asserting the expected “solved” outcome.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| maxMspPairDistance: 5, | ||
| } | ||
|
|
||
| test.skip("SchematicTracePipelineSolver_repro04", () => { |
There was a problem hiding this comment.
This test is intentionally skipped, but there’s no inline reason or tracking reference. Please add a brief comment (or include context in the test name) explaining what currently fails and, ideally, link to an issue/PR so it’s discoverable when it’s time to unskip.
Suggested change
| test.skip("SchematicTracePipelineSolver_repro04", () => { | |
| // TODO: Re-enable once this repro is fixed: `solver.solve()` does not currently | |
| // produce a solved result for this 9-pin J2 -> U1 mapping. Add the tracking | |
| // issue/PR link here when available so the skip is easy to revisit. | |
| test.skip("SchematicTracePipelineSolver_repro04: solver does not currently mark this 9-pin J2 -> U1 case as solved", () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SchematicTracePipelineSolver_repro04test for the J2 to U1 9-pin mapping caseWhy
This captures a concrete regression fixture for a pipeline case built from the reported J2/U1 layout and one-to-one pin connections.
Validation
bun test tests/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver_repro04.test.ts1 skip