fix(minibf): bound UTxO block lookups - #1204
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe UTxO route now performs block metadata lookups through an unordered stream with a maximum concurrency of 64. Missing metadata remains omitted, and lookup errors remain converted to ChangesUTxO block lookup concurrency
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This localized change bounds concurrent UTxO block lookups while preserving existing error and result handling, with relevant tests and formatting checks passing; no actionable merge-blocking risk remains. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #874.
What changed
join_allfan-out in the UTxO model loader with a futures streamblock_meta_by_tx_hashcalls at 64 withbuffer_unorderedValidation
cargo test -p dolos-minibf --lib(277 passed, 1 ignored)cargo fmt --all -- --checkgit diff --checkcargo clippy -p dolos-minibf --lib -- -D warningsis currently blocked by two pre-existingfor_kv_mapwarnings incrates/cardano/src/utxoset.rsandcrates/cardano/src/roll/dreps.rs; this PR does not touch those files.Summary by CodeRabbit