feat: add PerformUnion to MultiSearch to properly handle Union queries - #227
Merged
Conversation
- This method unmarshal the body and return `SearchResult` instead of `MultiSearchResult`. - Fixes typesense#226
Contributor
Author
tharropoulos
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR adds a dedicated
PerformUnionmethod toMultiSearchInterface. When performing a multi-search withUnion: true, the API returns a singleSearchResultrather than an array of results. The existingPerformmethod attempts to parse this into aMultiSearchResult, which does not map correctly. This fixes #226.Changes:
PerformUnionwhich forcesUnion: trueon the request body and parses the response directly intoapi.SearchResult.Union: falsetoPerformUnion.Notes on OpenAPI Spec:
The last PR #216 adding support for union search added the
hitsfield toMultiSearchResultin the local OpenAPI spec file but not in the shared Typesense API Spec. So a simplego generate ./...will override that PR's change.I have chosen not to run
go generate ./...in this PR, as pulling the latest spec introduces a lot of unrelated breaking changes to the Go client that should be handled in a separate major update.PR Checklist