Conversation
…screenDisplays CGDisplayCreateUUIDFromDisplayID is imported as Unmanaged<CFUUID>! (IUO) in Swift because the C header has no nullability annotation. It returns NULL for display ID 0 (kCGNullDirectDisplay), which the NSScreen.displayID extension can produce as a fallback during display state transitions. Calling .takeRetainedValue() on the nil IUO crashes with "Unexpectedly found nil while implicitly unwrapping an Optional value". The previous fix guarded CFUUIDCreateString instead, which was one line too late. Add guard for displayID != 0 and guard let on the IUO return value so invalid displays are skipped cleanly.
typester
force-pushed
the
fix/crash-when-display-disconnected2
branch
from
f15bd25 to
3e2b4ee
Compare
typester
pushed a commit
that referenced
this pull request
May 7, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.13](v0.1.12...v0.1.13) (2026-05-07) ### Bug Fixes * guard against nil CGDisplayCreateUUIDFromDisplayID in detectFullscreenDisplays ([#30](#30)) ([64255b1](64255b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CGDisplayCreateUUIDFromDisplayID is imported as Unmanaged! (IUO) in
Swift because the C header has no nullability annotation. It returns NULL for
display ID 0 (kCGNullDirectDisplay), which the NSScreen.displayID extension
can produce as a fallback during display state transitions.
Calling .takeRetainedValue() on the nil IUO crashes with "Unexpectedly found
nil while implicitly unwrapping an Optional value". The previous fix guarded
CFUUIDCreateString instead, which was one line too late.
Add guard for displayID != 0 and guard let on the IUO return value so
invalid displays are skipped cleanly.