Open
Conversation
use stdc++20 instead of 14 enable UI to fix FlexUI not compiling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove unneeded offset of vr camera position
with the -1.8 offset on the vr camera it would be under the map. now it is correctly with ground level at the ground. non vr camera still starts in the ground, as it did previously. id guess the -1.8 thing used to be needed but now its unneeded.
explicitely use python3 in regenerate script for compatability
some systems map python to python2, and some dont have it at all. generally its expected that python3 will exist so it should be used in unix scripts (https://peps.python.org/pep-0394/)
fix issues breaking compiling
update xcode signing identity and remove hardcoded id
refactor CreateProject script
made slightly more readable and added
__TMP_BUNDLE_DOMAIN__which would be like 'com.slindev'remove hardcoded bundle domain and add to CreateProject script
com.slindev was hardcoded, now it uses the above mentioned
__TMP_BUNDLE_DOMAIN__modernise gitignore
editor configs, lsp output, comments
clean up cmakelists making use of cmake variables
__TMP__variables by using cmakes${PROJECT_NAME}variable and setting variables at the start likeLIBRARY_NAMEandBUNDLE_ID$<TARGET_FILE_DIR:GRAB> $<TARGET_RUNTIME_DLLS:GRAB>target_compile_definitions. it seemed to be that way so it could accumulate definitions easier, buttarget_compile_definitionsaccumulates by default so that was redundant