File review page - Initial Commit#1075
Open
mbusch3 wants to merge 41 commits intoucfopen:new-main-page-UXfrom
Open
File review page - Initial Commit#1075mbusch3 wants to merge 41 commits intoucfopen:new-main-page-UXfrom
mbusch3 wants to merge 41 commits intoucfopen:new-main-page-UXfrom
Conversation
… print screen discrepancies.
… contentItems. Still needs module searching.
… print screen discrepancies.
… contentItems. Still needs module searching.
…eact-18 into file-review-page
… print screen discrepancies.
… contentItems. Still needs module searching.
… print screen discrepancies.
… contentItems. Still needs module searching.
…eact-18 into file-review-page
…Issues and ReviewFiles pages.
…rence preview window.
…ring data that could be out-of-date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still to do:
FileItem.phpfile return a "replacement" object IF it exists in the local database.Lots already in place: new page, divorced
FixIssuesPage.jsfromReviewFilesPage.js, LOTS of cleaning of old code as well.