Refactor DNS header decoding to simplify Z bits validation and update…#35
Refactor DNS header decoding to simplify Z bits validation and update…#35lohanidamodar wants to merge 2 commits intomainfrom
Conversation
… documentation for interoperability considerations
WalkthroughRemoved runtime validation of DNS Z bits (reserved bits 4–6 of the flags field) from Header::decode. The method no longer throws for non-zero Z bits; the docblock Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…oding for interoperability
… documentation for interoperability considerations
Summary by CodeRabbit
Bug Fixes
Tests