Set author email when parsing push events#45
Conversation
WalkthroughThe update enhances the GitHub webhook event handling by extracting the commit author's email address from the 'head_commit' section for 'push' events. This email is then included in the event data returned by the Changes
Estimated code review effort1 (~2 minutes) Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
src/VCS/Adapter/Git/GitHub.php
Outdated
| @@ -619,6 +620,7 @@ public function getEvent(string $event, string $payload): array | |||
| 'authorUrl' => $authorUrl, | |||
| 'authorAvatarUrl' => $authorAvatarUrl, | |||
| 'headCommitAuthor' => $headCommitAuthor, | |||
There was a problem hiding this comment.
This will be a breaking change, so it will require update in Appwrite's usage of library, but let's please rename this variable to headCommitAuthorName, to be consistent with newly added headCommitAuthorEmail.
There was a problem hiding this comment.
Agree on consistency - I was worried about backward compatibility.. if we can ensure compat, I'm down 👍
Summary by CodeRabbit