numfmt: do not panic on a multibyte whitespace field separator#13485
Merged
sylvestre merged 1 commit intoJul 21, 2026
Conversation
write_formatted_with_whitespace normalized the delimiter before the second and subsequent selected fields by writing a single space and dropping the first byte of the leading whitespace run with `&prefix[1..]`. That assumed an ASCII separator: WhitespaceSplitter splits on Unicode `char::is_whitespace`, so a multibyte separator (e.g. U+3000 IDEOGRAPHIC SPACE) made `&prefix[1..]` slice inside the character and abort with a char-boundary panic. Drop the first character instead of the first byte, using its UTF-8 length, so the slice always lands on a char boundary.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13482.
write_formatted_with_whitespacenormalized the delimiter before the 2nd+ selected field by writing a single space and dropping the first byte of the leading whitespace run with&prefix[1..]. That assumed an ASCII separator, butWhitespaceSplittersplits on Unicodechar::is_whitespace, so a multibyte separator (e.g. U+3000 IDEOGRAPHIC SPACE) made&prefix[1..]slice inside the character and abort:This drops the first character (by its UTF-8 length) instead of the first byte, so the slice always lands on a char boundary. Output becomes
1 2, exit 0.