feat(kiro): wire up new file-based session format (~May 2026)

[Sean10]

Follow-up to #230. Part 1 (maxBuffer + ToolUse) already landed in f2b77f9; this PR is Part 2 reworked around @vakovalskii's review feedback.

What & why

Kiro CLI moved to per-session files under ~/.kiro/sessions/cli/:

• <uuid>.json — metadata (session_id, cwd, title, created_at, updated_at)
• <uuid>.jsonl — events, one per line: Prompt → user, AssistantMessage → assistant, ToolResults → skipped

The previous version of Part 2 listed these sessions but wasn't wired end-to-end — detail/preview/search/replay/export all resolve through findSessionFile() / _buildSessionFileIndex(), which didn't know about kiro-cli, so opening a session returned "Session file not found" and the new found.format === 'kiro-cli' branches were never reached.

Changes (addressing review points)

1. Index the new files — _buildSessionFileIndex() now scans ~/.kiro/sessions/cli/*.jsonl and registers them as { format: 'kiro-cli', sessionId }, so findSessionFile() resolves them and every downstream consumer (detail, preview, search, replay, export) works end-to-end.
2. Path-traversal fix — loadKiroCliDetail() validates sessionId as a strict UUID before path.join, since it takes untrusted request input once wired. The scanner uses the same strict UUID pattern.
3. Fixture-based tests — new test/kiro-cli-session.test.js covers scan, detail parsing, path-traversal rejection, index resolution, and full end-to-end wiring (detail/preview/replay/export).

scanKiroCliSessions() + loadKiroCliDetail() carry the parsing; old SQLite-based Kiro sessions remain fully supported alongside the new format.

Testing

• node --test test/*.test.js → 207 pass, 2 skipped (win32-only), 0 fail
• New end-to-end test fails without the index wiring and passes with it

[vakovalskii]

Thanks for this — the file-based Kiro reader works and merges cleanly (all tests green, incl. the new ones). One blocker before merge, from a security pass:

Symlink traversal when reading session files (HIGH). The <uuid>.jsonl filenames are correctly UUID-validated (so ../ traversal is blocked), but fs.readFileSync(path.join(KIRO_SESSIONS_DIR, f)) still follows symlinks. A symlink named <valid-uuid>.jsonl inside ~/.kiro/sessions/cli/ pointing to e.g. ~/.ssh/id_rsa would be read and surfaced through the dashboard (detail / export / search / replay). This matters because codbash can be bound to a LAN address, and it's inconsistent with how the rest of the codebase already defends against this — see the Claude reader (src/data.js, ~line 679: if (entry.isSymbolicLink()) continue;) and isSafeLaunchPath in projects.js.

Two read sites are affected:

• the session-list loader (readFileSync of the meta/.jsonl)
• the detail loader (readFileSync(jsonlPath, ...))

Fix direction: before each read, reject symlinks / enforce containment, e.g.

const st = fs.lstatSync(p);
if (st.isSymbolicLink() || !st.isFile()) continue; // or: return null in the detail path

or fs.realpathSync(p) and verify it still starts with KIRO_SESSIONS_DIR + path.sep. Prefer lstat + isSymbolicLink to match the existing pattern.

No command-injection or prototype-pollution issues found in the new code — just this. Happy to merge once the symlink guard is in. 🙏

[Sean10]

Thanks for the careful review — good catch on the symlink follow. Fixed in 16e14ef.

The UUID check only blocked ../ traversal; readFileSync still followed symlinks. Guarded both read sites with lstat + isSymbolicLink, matching the existing Claude reader (if (entry.isSymbolicLink()) continue;):

• scanKiroCliSessions — readdirSync(..., { withFileTypes: true }) skips symlinked metadata; the .jsonl is lstat'd so a symlinked events file reports has_detail: false / file_size: 0.
• loadKiroCliDetail — lstat the .jsonl and refuse anything that isn't a regular file before reading.
• _buildSessionFileIndex — skip symlinked .jsonl too, for defense-in-depth (so it never resolves to { format: 'kiro-cli' }).

Added two tests that craft UUID-named symlinks pointing at out-of-tree files whose content would surface if followed (LEAKED-TITLE in metadata, LEAKED-CONTENT in events). I verified they fail with the guards removed and pass with them in place, so they actually bite rather than passing vacuously. Full suite: 209 pass, 2 skipped (win32-only), 0 fail — and re-confirmed against real data (125 CLI sessions still scan, legitimate sessions read fine).

[vakovalskii]

Проверил локально: ветка сливается в main без конфликтов, полный прогон node --test test/*.test.js — 253 passed / 0 failed вместе с #272–#276.

Единственное, что мешает: CI на ветке не запускался (no checks reported on 'feat/kiro-cli-file-format'). Пните ветку пустым коммитом или ребейзните на свежий main, чтобы workflow прогнался — тогда заберу в релиз-кандидат 7.16.0.

Спасибо за переработку части 2 под ревью 🙏

[vakovalskii]

@Sean10 вошло в 7.16.0 через релиз-кандидат #278 — релиз опубликован: https://github.com/vakovalskii/codbash/releases/tag/v7.16.0

Закрываю как включённое (в main коммиты пришли squash'ем от RC-ветки, поэтому автозакрытия не случилось). CI на вашей ветке так и не прогнался, но я проверил локально в общем стеке: тесты 253 passed / 0 failed, включая test/kiro-cli-session.test.js.

Спасибо за переработку части 2 под ревью — Kiro теперь читает пофайловый формат из ~/.kiro/sessions/cli во всех местах (detail, preview, поиск, replay, экспорт) 🙏