Skip to content

fix(terminal): dimmed text on a filled background no longer renders invisible #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vakovalskii wants to merge 1 commit into from
Closed

fix(terminal): dimmed text on a filled background no longer renders invisible #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/frontend/workspace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,16 @@ function _wsConnectPane(pane) {
var term = new Terminal({
cursorBlink: _tp.cursorBlink, cursorStyle: _tp.cursorStyle,
fontSize: _tp.fontSize, fontFamily: _tp.fontFamily,
theme: _wsTermTheme(), scrollback: 5000, allowProposedApi: true
theme: _wsTermTheme(), scrollback: 5000, allowProposedApi: true,
// Guarantee readable text against whatever background a TUI paints.
// Without this (xterm's default is 1 = no adjustment) *dimmed* text on a
// filled background renders as an apparently EMPTY highlighted bar — the
// WebGL renderer applies dim by cutting the foreground alpha, so e.g. the
// grey "message above" rows Claude Code draws lost their text entirely,
// while the same output stayed legible in iTerm. 4.5 is the WCAG AA ratio;
// xterm only nudges a foreground when it falls below it, so normal colors
// are left alone.
minimumContrastRatio: 4.5
});
var fit = new FitAddon.FitAddon();
term.loadAddon(fit);
Expand Down
Loading