few bugs, few operations, few algorithms...#1
Open
wilkeraziz wants to merge 12 commits into
Open
Conversation
…nd __imult__ which were returning None
…hat can compile pyx with --cython
Author
|
So, if you want you can check my fork to see how the package thing is looking like... then if you like I'll send you the request. Cheers! |
Author
|
Ops =P disregard this one... Cheers |
…act away (in client code) the type of semiring Fixed in *tpl: __iadd__ and __imul__
Owner
|
Thanks Wilker for all these contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Victor,
great job with the templates, I was trying to solve that and I was missing pystache.
Hey, I've made a few changes and added a few methods so that I could abstract a little more about the weight types in a few algorithms.
(Not for this pull request, but...) I wanted to ask you, if I organized the code in packages (including changing the setup.py, and changing the algorithms to pyx) would you feel like accepting another pull request?
I've tested here and it works, it is basically something like the following:
Then we would have a structure like:
from pyfst.fst import LogVectorFst
from pyfst.algorithm.sampling import sample