-
Notifications
You must be signed in to change notification settings - Fork 12
Optimize ingest indexing #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
59bff4c
Add keyword_tagger link for automatic tagging
howethomas 950bc3c
Add wtf_transcribe link for WTF transcription
howethomas 7f74f86
Ensure vcon version 0.3.0 for webhook compatibility
howethomas 161b623
Use HTTPS for apt sources in Dockerfile
howethomas 74e747b
Add SigNoz observability configuration
howethomas c2bcba9
Merge all feature branches into onsite-dev
howethomas cefef64
Add /stats/queue endpoint for Redis queue depth monitoring
howethomas bd0715f
Optimize vCon ingest by removing redundant Redis operations
howethomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| # SigNoz Observability Stack | ||
| # Usage: docker compose -f docker-compose.yml -f docker-compose.override.yml -f docker-compose.signoz.yml up -d | ||
| # | ||
| # After first run, execute schema migrations: | ||
| # docker run --rm --network conserver signoz/signoz-schema-migrator:latest sync --dsn='tcp://signoz-clickhouse:9000' | ||
| # | ||
| # Access UI at: http://localhost:3301 | ||
|
|
||
| networks: | ||
| conserver: | ||
| external: true | ||
|
|
||
| volumes: | ||
| signoz_clickhouse_data: | ||
| signoz_zookeeper_data: | ||
| signoz_zookeeper_log: | ||
| signoz_data: | ||
|
|
||
| services: | ||
| signoz-zookeeper: | ||
| image: zookeeper:3.9 | ||
| container_name: signoz-zookeeper | ||
| hostname: signoz-zookeeper | ||
| environment: | ||
| - ZOO_AUTOPURGE_PURGEINTERVAL=1 | ||
| - ZOO_4LW_COMMANDS_WHITELIST=mntr,ruok,stat | ||
| volumes: | ||
| - signoz_zookeeper_data:/data | ||
| - signoz_zookeeper_log:/datalog | ||
| networks: | ||
| - conserver | ||
| healthcheck: | ||
| test: ["CMD-SHELL", "echo ruok | nc localhost 2181 | grep imok"] | ||
| interval: 30s | ||
| timeout: 10s | ||
| retries: 3 | ||
| restart: unless-stopped | ||
|
|
||
| signoz-clickhouse: | ||
| image: clickhouse/clickhouse-server:24.1.2-alpine | ||
| container_name: signoz-clickhouse | ||
| hostname: signoz-clickhouse | ||
| tty: true | ||
| depends_on: | ||
| signoz-zookeeper: | ||
| condition: service_healthy | ||
| volumes: | ||
| - signoz_clickhouse_data:/var/lib/clickhouse | ||
| - ./signoz/zz-clickhouse-config.xml:/etc/clickhouse-server/config.d/zz-clickhouse-config.xml:ro | ||
| - ./signoz/clickhouse-users.xml:/etc/clickhouse-server/users.d/users.xml:ro | ||
| environment: | ||
| - CLICKHOUSE_DB=signoz_traces | ||
| - CLICKHOUSE_USER=default | ||
| - CLICKHOUSE_PASSWORD= | ||
| ulimits: | ||
| nofile: | ||
| soft: 262144 | ||
| hard: 262144 | ||
| networks: | ||
| - conserver | ||
| healthcheck: | ||
| test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://127.0.0.1:8123/ping"] | ||
| interval: 30s | ||
| timeout: 10s | ||
| retries: 3 | ||
| restart: unless-stopped | ||
|
|
||
| signoz-otel-collector: | ||
| image: signoz/signoz-otel-collector:latest | ||
| container_name: signoz-otel-collector | ||
| hostname: signoz-otel-collector | ||
| command: | ||
| - "--config=/etc/otel-collector-config.yaml" | ||
| depends_on: | ||
| signoz-clickhouse: | ||
| condition: service_healthy | ||
| environment: | ||
| - OTEL_RESOURCE_ATTRIBUTES=host.name=signoz-host,os.type=linux | ||
| volumes: | ||
| - ./signoz/otel-collector-config.yaml:/etc/otel-collector-config.yaml:ro | ||
| ports: | ||
| - "4317:4317" # OTLP gRPC receiver | ||
| - "4318:4318" # OTLP HTTP receiver | ||
| networks: | ||
| - conserver | ||
| healthcheck: | ||
| test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://127.0.0.1:13133/"] | ||
| interval: 30s | ||
| timeout: 10s | ||
| retries: 3 | ||
| restart: unless-stopped | ||
|
|
||
| signoz: | ||
| image: signoz/query-service:latest | ||
| container_name: signoz | ||
| hostname: signoz | ||
| depends_on: | ||
| signoz-clickhouse: | ||
| condition: service_healthy | ||
| environment: | ||
| - ClickHouseUrl=tcp://signoz-clickhouse:9000 | ||
| - SIGNOZ_LOCAL_DB_PATH=/var/lib/signoz/signoz.db | ||
| - DASHBOARDS_PATH=/root/config/dashboards | ||
| - STORAGE=clickhouse | ||
| - GODEBUG=netdns=go | ||
| - TELEMETRY_ENABLED=true | ||
| - DEPLOYMENT_TYPE=docker-standalone | ||
| volumes: | ||
| - signoz_data:/var/lib/signoz | ||
| - ./signoz/dashboards:/root/config/dashboards | ||
| ports: | ||
| - "3301:8080" # Web UI | ||
| networks: | ||
| - conserver | ||
| healthcheck: | ||
| test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://127.0.0.1:8080/api/v1/health"] | ||
| interval: 30s | ||
| timeout: 10s | ||
| retries: 3 | ||
| restart: unless-stopped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unauthenticated endpoint allows arbitrary Redis key querying
Medium Severity
The
/stats/queueendpoint is mounted directly onapp(no auth, like/healthand/version) but accepts an arbitrarylist_nameparameter that's passed directly toredis_async.llen(). Unlike the health endpoint, this allows unauthenticated callers to probe any Redis key — discovering queue names, measuring queue depths, and distinguishing key types (list keys return a count while non-list keys trigger aWRONGTYPEerror, returned as a 500). Consider restricting thelist_nameto a known allowlist of queue names or placing this endpoint behindapi_routerauthentication.