Refactor wtf_transcribe: decompose run(), fix imports, rename timeout options#153
Merged
pavanputhra merged 1 commit intomainfrom Apr 22, 2026
Merged
Refactor wtf_transcribe: decompose run(), fix imports, rename timeout options#153pavanputhra merged 1 commit intomainfrom
pavanputhra merged 1 commit intomainfrom
Conversation
…ix imports, rename timeout options - Decompose monolithic run() into ~15 small testable functions (dialog_to_binary, send_audio_to_vfun, transcribe_vcon_dialogs, verify_opts, etc.) - Fix stale import: server.lib.vcon_redis → lib.vcon_redis - Rename timeout → vfun-timeout; add url-timeout (separate timeout for URL fetching) - Remove min-duration option (filtering now left to upstream) - Return None instead of vcon_uuid when vCon missing or config invalid Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run()into ~15 small composable functions (dialog_to_binary,send_audio_to_vfun,transcribe_vcon_dialogs,verify_opts,url_dialog_to_binary, etc.)server.lib.vcon_redis→lib.vcon_redis(post-PR#137 restructuring)timeout→vfun-timeout; addedurl-timeout(separate timeout for fetching URL dialogs)min-durationoption — filtering responsibility moved upstreamNone(stops chain) instead ofvcon_uuidwhen vCon missing or config invalidTest plan
docker compose run --rm conserver pytest conserver/links/wtf_transcribe/ -vvfun-timeoutandurl-timeoutare respected in integration test against vfun serverNone) whenvfun-server-urlis not configured🤖 Generated with Claude Code