fix: persist Apache-2.0 license in package.json via additionalPackageJSON#312
Merged
Conversation
…JSON Adds license to gen.yaml so Speakeasy includes it on every generation run, preventing it from being overwritten. Addresses the concern raised in PR #311. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
❌ SDK Test Report: vercel — tests failed View Report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
license: Apache-2.0toadditionalPackageJSONin.speakeasy/gen.yamlWhy
PR #311 adds the
licensefield directly topackage.json, but Speakeasy rewritespackage.jsonon every generation run. Without this change, the license field would be overwritten and lost after the next generation.Setting it in
additionalPackageJSONensures Speakeasy includes it in every generatedpackage.json, making it permanent.Verification
After the next generation run, confirm: