Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for filtering OS images by instance type via ImagesService.get(instance_type=...) and refactors the Image model to a dataclass using dataclasses_json for (de)serialization consistency.
Changes:
- Refactor
verda.images.Imageto@dataclass+@dataclass_jsonand switch parsing toImage.from_dict(...). - Add optional
instance_typequery parameter toImagesService.get()and corresponding unit test. - Document the feature and refactor in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
verda/images/_images.py |
Converts Image to a dataclass/json model and adds instance_type filtering to the images list call. |
tests/unit_tests/images/test_images.py |
Refactors existing test payload reuse and adds a test asserting the instance_type query param is sent. |
CHANGELOG.md |
Notes the new query capability and the Image dataclass refactor under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
verda.images.get(instance_type=...)Changed
Imagemodel to use@dataclassand@dataclass_jsonfor consistency withInstanceandVolume