Skip to content

Feature/add instance type images query#93

Merged
tamirse merged 3 commits intomasterfrom
feature/add-instance-type-images-query
Apr 1, 2026
Merged

Feature/add instance type images query#93
tamirse merged 3 commits intomasterfrom
feature/add-instance-type-images-query

Conversation

@tamirse
Copy link
Copy Markdown
Collaborator

@tamirse tamirse commented Mar 31, 2026

Added

  • Support for querying OS images by instance type via verda.images.get(instance_type=...)

Changed

  • Refactored Image model to use @dataclass and @dataclass_json for consistency with Instance and Volume

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for filtering OS images by instance type via ImagesService.get(instance_type=...) and refactors the Image model to a dataclass using dataclasses_json for (de)serialization consistency.

Changes:

  • Refactor verda.images.Image to @dataclass + @dataclass_json and switch parsing to Image.from_dict(...).
  • Add optional instance_type query parameter to ImagesService.get() and corresponding unit test.
  • Document the feature and refactor in CHANGELOG.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
verda/images/_images.py Converts Image to a dataclass/json model and adds instance_type filtering to the images list call.
tests/unit_tests/images/test_images.py Refactors existing test payload reuse and adds a test asserting the instance_type query param is sent.
CHANGELOG.md Notes the new query capability and the Image dataclass refactor under Unreleased.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tamirse tamirse merged commit 5bd137e into master Apr 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants