Skip to content

Conversation

@jspc
Copy link
Member

@jspc jspc commented Feb 23, 2022

Create wifi management tooling, and hook it into netctl

jspc added 2 commits February 23, 2022 22:27
Given that sonar borked on this function before, for being too complicated, and given that wifi networks are handled in a completely different way anyway, this commit does some work towards splitting network configuration out into different places.
@github-actions
Copy link

github-actions bot commented Feb 23, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

10.9% 10.9% Coverage
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1890106927

  • 31 of 74 (41.89%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.4%) to 76.462%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bin/cmd/wifiConnect.go 3 11 27.27%
bin/cmd/wifi.go 3 16 18.75%
bin/cmd/wifiAdd.go 5 27 18.52%
Totals Coverage Status
Change from base Build 1888976195: -4.4%
Covered Lines: 510
Relevant Lines: 667

💛 - Coveralls

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

10.9% 10.9% Coverage
0.0% 0.0% Duplication

@coveralls
Copy link

coveralls commented Mar 9, 2025

Pull Request Test Coverage Report for Build 1890106927

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 29 of 72 (40.28%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.4%) to 76.462%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bin/cmd/wifiConnect.go 3 11 27.27%
bin/cmd/wifi.go 3 16 18.75%
bin/cmd/wifiAdd.go 5 27 18.52%
Totals Coverage Status
Change from base Build 1888976195: -4.4%
Covered Lines: 510
Relevant Lines: 667

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants