Add a health check for the worker processes#686
Open
jaredoconnell wants to merge 1 commit intovllm-project:mainfrom
Open
Add a health check for the worker processes#686jaredoconnell wants to merge 1 commit intovllm-project:mainfrom
jaredoconnell wants to merge 1 commit intovllm-project:mainfrom
Conversation
This is necessary because if this happens presently, it doesn't detect the failure, and continues waiting idefinitely for the process to be ready, causing a hang. Generated-by: Cursor AI Signed-off-by: Jared O'Connell <joconnel@redhat.com>
sjmonson
approved these changes
Apr 4, 2026
Collaborator
sjmonson
left a comment
There was a problem hiding this comment.
Didn't test but looks fine. See minor nits below.
Comment on lines
+300
to
+302
| " Consider an alternative multiprocessing start method" | ||
| " (spawn, fork, forkserver) via the" | ||
| " GUIDELLM__MP_CONTEXT_TYPE environment variable" |
Collaborator
There was a problem hiding this comment.
I don't like this error message because its making an assumption of the cause that we cannot guarantee.
| detail = self._worker_error_details or "error_event is set" | ||
| raise RuntimeError(f"Worker process group startup failed: {detail}") | ||
|
|
||
| async def _process_health_monitor(self): |
Collaborator
There was a problem hiding this comment.
This might make more sense as a thread since we are querying information on other processes and that could be i/o blocking. Not 100% sure though so will not block merge on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates an Async IO task that polls for failure of the worker processes.
This is necessary because if this happens presently, it doesn't detect the failure, and continues waiting idefinitely for the process to be ready, causing a hang.
Details
Here is what it looks like with a segmentation fault, which I've been getting.
In this situation, all of them had segmentation faults at the same time for some reason. The system reported a segmentation fault to me.
Test Plan
Use of AI
## WRITTEN BY AI ##)