SqlLine integration#17
Conversation
|
The issue which I currently faced is that it looks like jna/jansi could not handle ctrl-c correctly in eclipse env... It leads to endless loop. |
8eeca25 to
b052c4e
Compare
|
I tried with MAT 1.10.0 + Sqlline 1.9.0 + macOS, and it seems to work (including ctrl+c) |
| import java.util.Set; | ||
|
|
||
| public class MCPApplication extends Application { | ||
| private static final Set<String> ALLOWED_SQLLINE_COMMANDS = new HashSet<String>() {{ |
There was a problem hiding this comment.
@snuyanzin , I might be late here :) Do you remember by chance why do you limit the set of commands?
There was a problem hiding this comment.
As far as I remember there are database specific commands e.g. !isolation, !drop and etc.
The idea was to limit to set of commands which makes sense for mat-calcite-plugin.
Agree that the list of commands itself is the subject for discussion.
just checked: for me it is still reproducing. It seems Linux specific. Based on trace jline3 uses System specific pty (in my case LinuxNativePty). I suppose that could be a reason why on macOS it could work |
The PR suggests initial integration with SqlLine mentioned at #9.
Some sqlline commands are hidden, especially for mat-calcite-plugin there is added
!open_dumpShort demo how it currently looks like https://asciinema.org/a/251789, https://asciinema.org/a/251617
Startup:
./MemoryAnalyzer -application MatCalcitePlugin.execute sqlline