Allow log function callback instead of log file for c2mir messages #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 10, 2024 15:39
…ng a log function in c2mir_options rather than needing to create, write, read, and parse a log file In c2mir, n_errors was only incremented if message_file was assigned a file stream, potentially leading to different behavior for debug and release isprint was asserting when token_code > 255 in get_token_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow easier embedding into applications, especially an IDE, by setting a log function in c2mir_options rather than needing to create, write, read, and parse a log file
In c2mir, n_errors was only incremented if message_file was assigned a file stream, potentially leading to different behavior for debug and release
isprint was asserting when token_code > 255 in get_token_name