-
Notifications
You must be signed in to change notification settings - Fork 613
process_spoofing plugin #1826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process_spoofing plugin #1826
Conversation
|
68b51e8 to
5e654b1
Compare
ikelos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission and sorry it took so long to find time to review, this plugin looks fun! It's mostly fine, but it smushes the results together into a string, which is longwinded for humans to read and difficult for programs/plugins to parse. Hopefully this should be pretty straight forward to refactor into returning boolean values. It also feels like as number of the methods here may be useful for other plugins, so first check that other plugins don't already implement them and otherwise consider converting them into classmethods so that they can be called externally...
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
9b8f701 to
b7a1bec
Compare
|
86352c6 to
91ff5eb
Compare
ikelos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks really good, just minor quibbles, but honestly it could go in like this if you're tired of tweaking it! Thanks very much for putting up with my schedule, it's really appreciated as are your plugins! 5:)
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
volatility3/framework/plugins/linux/malware/process_spoofing.py
Outdated
Show resolved
Hide resolved
41fa262 to
9c5950e
Compare
ikelos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! 5:) We can merge as soon as the tests complete...
Hello, just playing with memory & OS internals.
apparently some legitimate processes do these techniques to have enriched information in their cmdline or so. here are some such processes: