fix(openclaw-plugin): resolve agentId shadowing and deduplicate utilities#1034
Closed
mobilebarn wants to merge 1 commit intovolcengine:mainfrom
Closed
fix(openclaw-plugin): resolve agentId shadowing and deduplicate utilities#1034mobilebarn wants to merge 1 commit intovolcengine:mainfrom
mobilebarn wants to merge 1 commit intovolcengine:mainfrom
Conversation
…ties - Rename inner resolveAgentId to resolveSessionAgentId to prevent shadowing the module-level function - Fix misleading agentId placeholder/help in openclaw.plugin.json - Deduplicate md5Short (keep in client.ts, import in context-engine.ts) - Deduplicate normalizeDedupeText (keep in text-utils.ts, import in memory-ranking.ts) Refs volcengine#948
|
Failed to generate code suggestions for PR |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveAgentIdclosure inindex.tstoresolveSessionAgentIdto prevent shadowing the module-levelresolveAgentIdfromconfig.tsagentIdplaceholder/help text inopenclaw.plugin.json— the actual default is"default", not a random unique IDmd5Short(keep exported inclient.ts, import incontext-engine.ts)normalizeDedupeText(keep exported intext-utils.ts, import inmemory-ranking.ts)Refs #948
Test plan
resolveSessionAgentIdis called correctly inbefore_prompt_build,memory_store, andcreateMemoryOpenVikingContextEnginemd5Shortimport incontext-engine.tsresolves correctlynormalizeDedupeTextimport inmemory-ranking.tsresolves correctly