-
Notifications
You must be signed in to change notification settings - Fork 115
chore: add projection read/write example to quickstart tests #5918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add projection read/write example to quickstart tests #5918
Conversation
|
@joseph-isaacs I'm not sure if this test is appropriate; if it isn't, I can close the pr. |
vortex/src/lib.rs
Outdated
| session | ||
| .write_options() | ||
| .write( | ||
| &mut tokio::fs::File::create("example_projection.vortex").await?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should put this in a temp dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation is mainly based on the implementation of other tests. The file will be deleted after the test passes. If it's to be placed in a temporary directory, should other tests also be modified accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you want to prefix the path with cargo manifest, see:
| .join(env!("CARGO_MANIFEST_DIR")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thanks. I also modified other tests to make them more standardized.
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
455d67e to
8defb4d
Compare
Signed-off-by: cancaicai <[email protected]>
8defb4d to
aec44e2
Compare
Gives users a minimal, end-to-end example of: - writing a multi-column struct, - reading it back with a projection expression, - understanding how `with_projection(select([...], root()))` behaves. Signed-off-by: cancaicai <[email protected]>
Gives users a minimal, end-to-end example of: - writing a multi-column struct, - reading it back with a projection expression, - understanding how `with_projection(select([...], root()))` behaves. Signed-off-by: cancaicai <[email protected]>
Gives users a minimal, end-to-end example of:
with_projection(select([...], root()))behaves.