Skip to content

Conversation

@caicancai
Copy link
Contributor

Gives users a minimal, end-to-end example of:

  • writing a multi-column struct,
  • reading it back with a projection expression,
  • understanding how with_projection(select([...], root())) behaves.

@caicancai
Copy link
Contributor Author

@joseph-isaacs I'm not sure if this test is appropriate; if it isn't, I can close the pr.

session
.write_options()
.write(
&mut tokio::fs::File::create("example_projection.vortex").await?,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should put this in a temp dir

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is mainly based on the implementation of other tests. The file will be deleted after the test passes. If it's to be placed in a temporary directory, should other tests also be modified accordingly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you want to prefix the path with cargo manifest, see:

.join(env!("CARGO_MANIFEST_DIR"))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks. I also modified other tests to make them more standardized.

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.68%. Comparing base (49b1634) to head (aec44e2).
⚠️ Report is 41 commits behind head on develop.

Files with missing lines Patch % Lines
vortex/src/lib.rs 97.36% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@caicancai caicancai force-pushed the feat/projection-read-write-example branch 2 times, most recently from 455d67e to 8defb4d Compare January 13, 2026 14:03
@caicancai caicancai force-pushed the feat/projection-read-write-example branch from 8defb4d to aec44e2 Compare January 13, 2026 14:04
@joseph-isaacs joseph-isaacs added the chore Release label indicating a trivial change label Jan 13, 2026
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) January 13, 2026 14:07
@joseph-isaacs joseph-isaacs merged commit 5cd8b29 into vortex-data:develop Jan 13, 2026
54 of 56 checks passed
AdamGS pushed a commit that referenced this pull request Jan 13, 2026
Gives users a minimal, end-to-end example of:
  - writing a multi-column struct,
  - reading it back with a projection expression,
  - understanding how `with_projection(select([...], root()))` behaves.

Signed-off-by: cancaicai <[email protected]>
AdamGS pushed a commit that referenced this pull request Jan 13, 2026
Gives users a minimal, end-to-end example of:
  - writing a multi-column struct,
  - reading it back with a projection expression,
  - understanding how `with_projection(select([...], root()))` behaves.

Signed-off-by: cancaicai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants