Skip to content

Conversation

@techsk8
Copy link
Contributor

@techsk8 techsk8 commented Jul 10, 2025

I'm using packages that have gitlab tags starting with v1.7.0 and currently the case it's not covered.

  python::pip { 'ipmigrate_ice_service_cli':
    ensure       => 'v1.7.0',
    install_args => '-U',
    pkgname      => 'instance-service-cli',
    virtualenv   => '/opt/ipmigrate',
    url          => 'git+ssh://[email protected]/project-group/instance-service-cli.git',
    timeout      => 30,
    require      => Python::Pyvenv['/opt/ipmigrate'],
    before       => Exec['install_pip_ipmigrate'],
  }

currently I get: ensure can be a version number or one of: present, absent, latest.

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a test to https://github.com/voxpupuli/puppet-python/blob/master/spec/defines/pip_spec.rb which uses a version number starting with a v? Other than that, this seems fine to me. 👍

@kenyon kenyon changed the title add posibility to insert pkg versions starting with v pip: allow versions starting with v Jul 10, 2025
@kenyon kenyon added the enhancement New feature or request label Jul 10, 2025
@techsk8
Copy link
Contributor Author

techsk8 commented Jul 11, 2025

Opened #727 with a proper branch name. Closing this one.

@techsk8 techsk8 closed this Jul 11, 2025
@techsk8 techsk8 deleted the add_ensure_option branch July 11, 2025 11:30
@kenyon kenyon added skip-changelog Excluded from CHANGELOG and removed enhancement New feature or request labels Jul 11, 2025
@kenyon
Copy link
Member

kenyon commented Jul 11, 2025

For future reference, branch name doesn't matter, so no need to create a new PR because of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Excluded from CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants