Add Row Editing Highlight and Tap-to-Edit support for Row selection Mode#342
Open
rashmi-thakurr wants to merge 1 commit intow-ahmad:mainfrom
Open
Add Row Editing Highlight and Tap-to-Edit support for Row selection Mode#342rashmi-thakurr wants to merge 1 commit intow-ahmad:mainfrom
rashmi-thakurr wants to merge 1 commit intow-ahmad:mainfrom
Conversation
cf3ad20 to
5dbf5b6
Compare
5dbf5b6 to
7264709
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds visual row-editing highlight and tap-to-edit support for Row and CellOrRow selection modes, so the active row is clearly indicated while a cell is being edited, matching Windows File Explorer's behavior.
Closes #336
Key Implementation Details
stops.
selects).
Test Coverage
7 new tests in TableViewRowEditingTests.cs covering: editing highlight in Row mode, editing highlight in CellOrRow mode, pointer hover prerequisites, tap-to-edit prerequisites, virtualization recycling, current-cell state reset, and editing state transitions across rows.
All 173 tests pass (existing + new).
Files Changed
4 files changed, +400 / −6 lines
src/TableView.cssrc/TableViewCell.cssrc/TableViewRow.cstests/TableViewRowEditingTests.cs