Wait for the PositionWatcher thread to stop#1109
Open
aronbierbaum wants to merge 12 commits into
Open
Conversation
|
a simple |
aronbierbaum
force-pushed
the
wait_directsound_thread
branch
from
58eccea to
d45f6ae
Compare
aronbierbaum
force-pushed
the
wait_directsound_thread
branch
from
d45f6ae to
59b8bc8
Compare
aronbierbaum
force-pushed
the
wait_directsound_thread
branch
from
59b8bc8 to
b46e8a2
Compare
aronbierbaum
force-pushed
the
wait_directsound_thread
branch
from
b46e8a2 to
705ad03
Compare
aronbierbaum
force-pushed
the
wait_directsound_thread
branch
from
d63024f to
7f99878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change closing a
AVPlayermight crash because thePositionWatcherthread has not stopped before theAVPlayeris destroyed.