review-pr: harden Pre-Verdict Audit against comment-quality halo effect - #54
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
review-pr: harden Pre-Verdict Audit against comment-quality halo effect#54warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Require the audit to enumerate each added/changed comment individually with its file:line, and forbid treating a comment's writing quality, technical accuracy, or the importance of the issue it describes as a mitigating factor for a guideline violation. Also covers repositories with no written commenting guidelines by falling back to the existing codebase's own commenting norms. Co-Authored-By: Warp <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rewrites the
- **Comments**:bullet under## Pre-Verdict Auditin.agents/skills/review-pr/SKILL.md. Nothing else in the file changes.The audit now requires the reviewer to:
file:line, so none get skimmed past as part of a holistic impression.Why
A reviewer using this skill let a comment's writing quality and technical accuracy ("well-written, explains a genuinely hard bug") stand in for actually checking it against the target repo's commenting guidelines, and missed confirmed rule violations as a result. Per-comment enumeration removes the halo effect, and the explicit prohibition removes the excuse.
The wording stays generic on purpose: no specific rule names or categories are introduced, so the skill still applies to repositories with or without written commenting guidelines.
Scope
One line changed. Schema, severity labels, safety rules, evidence rules, suggestion-block constraints, and the diff-line-annotation contract are untouched.
Conversation: https://staging.warp.dev/conversation/5e46bb2e-9a34-43ae-862f-bb18d4c1572d
Run: https://oz.staging.warp.dev/runs/019ff3c6-d39c-7218-a1c8-33839d68b1a9
This PR was generated with Oz.