review-pr: harden Pre-Verdict Audit against comment-quality halo effect - #55
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
review-pr: harden Pre-Verdict Audit against comment-quality halo effect#55warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Require the audit to enumerate each added/changed comment individually with its file:line, fall back to the codebase's own commenting norms when the repository defines no guidelines, and forbid treating a comment's writing quality, technical accuracy, or importance as a mitigating factor for a guideline violation. Co-Authored-By: Warp <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Hardens the
## Pre-Verdict Auditcomment check in.agents/skills/review-pr/SKILL.mdagainst a halo effect: a reviewer previously let a comment's writing quality and technical accuracy ("well-written, explains a genuinely hard bug") stand in for actually checking it against the target repo's commenting guidelines, and missed confirmed rule violations as a result.Change
The
**Comments**bullet now:file:line, so none get skimmed past as part of a holistic impression;The guidance stays generic: no specific rule names or comment categories are introduced, so it still applies to repos with and without explicit commenting guidelines.
Scope
Documentation only, one line in one section. The schema, severity labels, safety rules, evidence rules, suggestion-block constraints, and diff-line-annotation contract are untouched, as is the
**Tests**bullet and the section heading and intro.Conversation: https://staging.warp.dev/conversation/1e1e1155-05d6-413b-b8bc-67ebdcd7910a
Run: https://oz.staging.warp.dev/runs/019ff3c6-db33-773a-bc56-b3f12b3ba741
This PR was generated with Oz.