review-pr: harden Pre-Verdict Audit against comment-quality halo effect - #56
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
review-pr: harden Pre-Verdict Audit against comment-quality halo effect#56warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
The Pre-Verdict Audit's comment check allowed a holistic impression to stand in for a per-comment check, so a well-written comment could be skimmed past without being measured against the repository's commenting guidelines. Require enumerating each added or changed comment with its file:line, give a fallback standard for repos without written guidelines, and state explicitly that writing quality, technical accuracy, or the importance of the issue a comment describes never excuses a violation. Co-Authored-By: Warp <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hardens the Comments bullet of
## Pre-Verdict Auditin.agents/skills/review-pr/SKILL.md.Why
A reviewer using this skill let a comment's writing quality and technical accuracy ("well-written, explains a genuinely hard bug") stand in for actually checking it against the target repository's commenting guidelines, and missed confirmed rule violations as a result. The old wording ("check every comment ... against the repository's own commenting guidelines") was satisfiable by a holistic impression, which is exactly how a good-looking comment gets skimmed past.
Change
The bullet now:
file:line, so none is absorbed into a general impression of the diff;Scope
Documentation only, one line in one section. No specific rule names or categories are introduced, so the skill stays generic across repositories with and without explicit commenting guidelines. The schema, severity labels, safety rules, evidence rules, suggestion-block constraints, and diff-line-annotation contract are untouched.
Conversation: https://staging.warp.dev/conversation/fe82fcbf-bc05-48e9-8d3e-6416a0d87098
Run: https://oz.staging.warp.dev/runs/019ff4a3-1c98-74c9-8eaf-1a02ca29cac2
This PR was generated with Oz.