review-pr: harden Pre-Verdict Audit against comment-quality halo effect - #57
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
Conversation
Require enumerating every added or changed comment individually with its file:line and checking each against the repository's commenting guidelines (or, absent guidelines, the project's existing commenting norms). Forbid treating a comment's writing quality, technical accuracy, or the importance of the issue it describes as a mitigating factor for a guideline violation. Co-Authored-By: Warp <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Documentation-only change to
.agents/skills/review-pr/SKILL.md, limited to the## Pre-Verdict Auditsection's Comments bullet.Why
A reviewer using this skill let a comment's writing quality and technical accuracy ("well-written, explains a genuinely hard bug") stand in for actually checking it against the target repo's commenting guidelines, and missed confirmed rule violations as a result.
What changed
The Comments bullet now:
file:line, so none get skimmed past as part of a holistic impression.No rule names or categories are introduced, so the skill stays generic across repos with and without explicit commenting guidelines. Nothing else in the file changed — the schema, severity labels, safety rules, evidence rules, suggestion-block constraints, and diff-line-annotation contract are untouched, as is the Tests bullet.
Conversation: https://staging.warp.dev/conversation/c1500141-7376-47dd-a966-91d76eb38fd4
Run: https://oz.staging.warp.dev/runs/019ff4a3-2387-705e-83bb-ef65542b64cb
This PR was generated with Oz.