review-pr: harden Pre-Verdict Audit against comment-quality halo effect - #58
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
review-pr: harden Pre-Verdict Audit against comment-quality halo effect#58warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Require enumerating each added/changed comment individually (file:line) and checking it against the repo's own commenting guidelines, or against the existing commenting distribution when no guidelines are defined. Explicitly forbid treating a comment's writing quality, technical accuracy, or the subtlety/importance of the issue it describes as a mitigating factor for guideline violations. Co-Authored-By: Warp Agent <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the
review-prskill's## Pre-Verdict Auditsection against a "comment-quality halo effect": a reviewer previously let a comment's writing quality or technical accuracy ("well-written, explains a genuinely hard bug") substitute for actually checking it against the target repo's commenting guidelines, and missed confirmed rule violations as a result.Change
Documentation-only edit to exactly one bullet under
## Pre-Verdict Auditin.agents/skills/review-pr/SKILL.md:No rule names or categories are introduced; the skill stays generic across repos with or without explicit written commenting guidelines.
Scope
Only the Comments bullet under
## Pre-Verdict Auditchanged. The Tests bullet, the heading, its intro sentence, and everything else in the file (schema, severity labels, safety rules, evidence rules, suggestion-block constraints, diff-line-annotation contract) are untouched. Verified withgit --no-pager diff: 1 file changed, 1 insertion(+), 1 deletion(-).Conversation: https://staging.warp.dev/conversation/b4b70abe-a864-4588-a835-a1df9b950f9b
Run: https://oz.staging.warp.dev/runs/019ff4a4-6841-7c23-b9f0-14b13ca98138
This PR was generated with Oz.
Co-Authored-By: Warp Agent agent@warp.dev