review-pr: harden Pre-Verdict Audit against comment-quality halo effect - #60
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
review-pr: harden Pre-Verdict Audit against comment-quality halo effect#60warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Require enumerating each added/changed comment individually (with file:line) when checking it against the repo's commenting guidelines, and explicitly forbid treating a comment's writing quality, technical accuracy, or the subtlety/importance of what it explains as a mitigating factor for a guideline violation. Co-Authored-By: Warp Agent <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the
## Pre-Verdict Auditsection of thereview-prskill so a reviewer can no longer let a comment's writing quality or technical accuracy substitute for actually checking it against the target repo's commenting guidelines.Background: a reviewer using this skill let a comment's writing quality/technical accuracy ("well-written, explains a genuinely hard bug") substitute for actually checking it against the target repo's commenting guidelines, and missed confirmed rule violations as a result — a "comment-quality halo effect."
Changes
## Pre-Verdict Auditnow requires listing every added/changed comment (doc comment or inline) one by one with its file:line, and checking each individually — rather than a holistic pass — against the repo's commenting guidelines (or, absent explicit guidelines, against the commenting distribution of existing code in the project).Verification
git diffshows exactly one changed hunk in.agents/skills/review-pr/SKILL.md: one line removed, one line added (the Tests bullet is untouched). No other file is touched.Conversation: https://staging.warp.dev/conversation/92699808-32bb-4839-8a21-b03e5eb1733f
Run: https://oz.staging.warp.dev/runs/019ff4a4-6558-7f41-8b16-9b4805ab6d2b
This PR was generated with Oz.