Skip to content

review-pr skill: harden Pre-Verdict Audit Comments bullet - #61

Draft
warp-agent-staging[bot] wants to merge 1 commit into
eval-base/019ff1e1from
factory-ab-eval/pre-verdict-audit-comments
Draft

review-pr skill: harden Pre-Verdict Audit Comments bullet#61
warp-agent-staging[bot] wants to merge 1 commit into
eval-base/019ff1e1from
factory-ab-eval/pre-verdict-audit-comments

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Hardens the ## Pre-Verdict Audit section of the review-pr skill (.agents/skills/review-pr/SKILL.md). A reviewer using this skill let a comment's writing quality and technical accuracy ("well-written, explains a genuinely hard bug") substitute for actually checking it against the target repo's commenting guidelines, and missed confirmed rule violations as a result.

Changes

  • The Comments bullet under ## Pre-Verdict Audit now requires enumerating every comment (doc comment or inline) the diff adds or changes, one by one with its file:line, and checking each individually against the repository's own commenting guidelines — or, absent explicit guidelines, against the commenting distribution of existing code in the project.
  • Explicitly states that compliance must be evaluated independently of a comment's writing quality, technical accuracy, or the subtlety/importance of the issue it describes — none of those qualities excuses a guideline violation or a mismatch with the codebase's own norms.
  • No specific rule names or categories (e.g. "transformation comments") are introduced, so the skill remains generic across repos with and without explicit written commenting guidelines.
  • Nothing else in the file changed: the schema, severity labels, safety rules, evidence rules, suggestion-block constraints, and diff-line-annotation contract are untouched, as is the ## Pre-Verdict Audit heading and its intro sentence.

Verification

Documentation-only change. Verified with git diff that exactly one file changed, with exactly one line removed and one line added (the Comments bullet content); the Tests bullet and everything else in the file is unchanged.

Conversation: https://staging.warp.dev/conversation/61b50bac-49aa-44d2-b38f-ae047ab87b5d
Run: https://oz.staging.warp.dev/runs/019ff4a5-10cb-7d1b-9b72-9eec202a9fbc

This PR was generated with Oz.

Require enumerating every comment individually by file:line and checking
each against the repository's commenting guidelines (or, absent explicit
guidelines, the commenting distribution of existing code), while
explicitly forbidding comment quality/importance from excusing a
guideline violation.

Co-Authored-By: Warp Agent <agent@warp.dev>
@warp-agent-staging warp-agent-staging Bot added the factory-ab-eval Factory A/B evaluation replay label Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

factory-ab-eval Factory A/B evaluation replay

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant