review-pr skill: harden Pre-Verdict Audit Comments bullet - #61
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
review-pr skill: harden Pre-Verdict Audit Comments bullet#61warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Require enumerating every comment individually by file:line and checking each against the repository's commenting guidelines (or, absent explicit guidelines, the commenting distribution of existing code), while explicitly forbidding comment quality/importance from excusing a guideline violation. Co-Authored-By: Warp Agent <agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the
## Pre-Verdict Auditsection of thereview-prskill (.agents/skills/review-pr/SKILL.md). A reviewer using this skill let a comment's writing quality and technical accuracy ("well-written, explains a genuinely hard bug") substitute for actually checking it against the target repo's commenting guidelines, and missed confirmed rule violations as a result.Changes
## Pre-Verdict Auditnow requires enumerating every comment (doc comment or inline) the diff adds or changes, one by one with its file:line, and checking each individually against the repository's own commenting guidelines — or, absent explicit guidelines, against the commenting distribution of existing code in the project.## Pre-Verdict Auditheading and its intro sentence.Verification
Documentation-only change. Verified with
git diffthat exactly one file changed, with exactly one line removed and one line added (the Comments bullet content); the Tests bullet and everything else in the file is unchanged.Conversation: https://staging.warp.dev/conversation/61b50bac-49aa-44d2-b38f-ae047ab87b5d
Run: https://oz.staging.warp.dev/runs/019ff4a5-10cb-7d1b-9b72-9eec202a9fbc
This PR was generated with Oz.