Fix over-triggering description on respond-to-pr-comments-in-blocklist - #69
Conversation
… fix over-triggering description The description led with wording that overlapped almost entirely with the bundled pr-comments skill (fetching/displaying PR comments), had no negative trigger, and used the ambiguous verb "responding" without naming the actual terminal action (posting GitHub replies and resolving review threads via ask_user_question-gated approval). This caused the skill to be read whenever PR comments were in play, even when the user only wanted comments fetched/displayed or code changes made without any GitHub posting. Also drops the misleading -in-blocklist suffix, which referred to Warp's terminal block list UI and had no connection to any filtering mechanism in this repo. Co-Authored-By: Warp Agent <agent@warp.dev>
|
This PR was generated with Warp. |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
The requester decided to drop the directory/name rename to avoid downstream skills-lock.json reconciliation risk in warp-server and warp (skills add is additive, not reconciling, so a rename would have left a stale entry pointing at a removed path). Keeps the over- triggering description rewrite and the new When not to use this skill section, which is the actual fix and reviewed clean. Co-Authored-By: Warp Agent <agent@warp.dev>
There was a problem hiding this comment.
Overview
This PR renames the PR-comment response skill and narrows its selection description so it is reserved for the interactive workflow that posts GitHub replies and resolves review threads. The added "When not to use this skill" section mirrors that trigger boundary in the body.
Concerns
- No blocking concerns found.
- No approved or repository spec context was provided, so there is no spec drift to flag.
- Security pass found no security-sensitive behavior changes; this is documentation/skill metadata only.
- Comment/prose audit found the changed skill description and added guidance aligned with the repository's skill format. No tests were added or changed.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz


Summary
A Warp engineer reported that the
respond-to-pr-comments-in-blocklistskill was read every time PR comments were handed to the agent, even when the user only wanted the comments fetched/displayed or the underlying code fixed, with no intent to post anything to GitHub.Root cause
The frontmatter
descriptionhad three defects:pr-commentsskill's own description ("Fetch and display GitHub PR review comments for the current branch"). Neither description stated a boundary, so this skill's description matched any context where PR comments were in play, including when they were already fetched. The body does state the correct boundary ("If comments are already visible in the conversation... continue from that context"), but that's only visible after the very read this was supposed to prevent — skill selection happens on name + description alone.ask_user_questionworkflow whose terminal action is posting[Warp Agent]-prefixed replies via the GitHub REST API and resolving threads via theresolveReviewThreadGraphQL mutation — none of that was visible in the description.claude-apiskill'sTRIGGER when: ... SKIP: ...block).Changes
descriptionto lead with the terminal action (posting replies / resolving threads), name the interactive nature of the workflow, and state explicit exclusions pointing atpr-commentsand at code-only requests.This PR does not rename the skill directory or its
name:frontmatter. A rename was considered (the-in-blocklistsuffix is dead weight — it refers to Warp's terminal block list UI, not any filtering mechanism in this repo) but was dropped: this skill is redistributed towarp-serverandwarpvia their checked-inskills-lock.json, and the regeneration tooling (scripts/update_common_skills_lock, viaskills add ... -s '*') is additive rather than reconciling — a reproduction against a downstream lock confirmed a rename would leave both the old (now-removed) path and the new path in the regenerated lock, breaking lock-based installs. Renaming is left for separate follow-up work that also fixes the lock reconciliation gap. With no rename, this PR has no redistribution/lockfile impact.Verification
This is a behavioral/prompt-engineering change, not something covered by CI. I attempted to use the bundled
create-skillskill's trigger-eval tooling (scripts/run_eval.py) to quantitatively confirm the new description stops the misfires, but it shells out to theclaudeCLI (Claude Code) to run each eval query, andclaudeis not installed in this environment — so I could not run it. Verification here is a manual read-through:pr-comments's "fetch and display" framing.pr-comments), or only wants the code changes made without posting anything back to GitHub" — directly addressing the reported false-trigger cases.Related
There is an existing stale draft PR, #34, which also renames this skill (as part of a broader "make common-skills Warp-agnostic" migration) but leaves the description unchanged. Per the requester, that PR is not being coordinated with here.