review-pr: add error-reporting form to the Pre-Verdict Audit (APP-5522) - #76
Draft
warp-agent-staging[bot] wants to merge 1 commit into
Draft
review-pr: add error-reporting form to the Pre-Verdict Audit (APP-5522)#76warp-agent-staging[bot] wants to merge 1 commit into
warp-agent-staging[bot] wants to merge 1 commit into
Conversation
Add a third mandatory audit category (alongside Comments and Tests) that requires listing every error-reporting call the diff touches, one by one with file:line, and checking each against the repository's own error-reporting guidance. Declare error-reporting form as an overridable category so companion skills (e.g. warp's review-pr-local) can supply the repo-specific substance. Per APP-5522: on warp's PR #13483, this category didn't exist, so ~974 new report_error! lines got zero form findings despite the companion skill already naming the anti-pattern in prose.
4 tasks
warp-agent-staging
Bot
added
the
factory:wilson
Contributor
Author
|
This PR was generated with Warp. Comment   |
acarl005
pushed a commit
to warpdotdev/warp
that referenced
this pull request
Aug 19, 2026
…15296) ## Description Review-prompting fix for [APP-5522](https://linear.app/warpdotdev/issue/APP-5522/fix-report-error-demotions-of-typed-errors-into-extra-and-related-form) (the code-side `report_error!` form fixes are a separate PR). `.agents/skills/review-pr-local/SKILL.md` already named the "typed error demoted into `extra:`" anti-pattern (added in [#13483](#13483) itself), but only as one prose bullet inside a long list — so it was easy to under-apply on that PR's 345-file, ~974-`report_error!`-line diff, which is exactly what happened: the bot's review found 2 unrelated compile bugs and zero form findings, including on the very lines (`crates/warpui_core/src/runtime/mod.rs:813` and `:709`) that used the forbidden form. Companion PR (adds the matching mandatory-audit category to the core skill): warpdotdev/common-skills#76 This is a review-prompting-only change (skill markdown). No Rust code is touched; a separate PR fixes the flagged `report_error!` call sites themselves. - [ ] The linked issue is labeled `ready-to-spec` or `ready-to-implement`. - [x] N/A — no screenshots/video; this is a skill-markdown change with no UI impact. ## Linked Issue [APP-5522](https://linear.app/warpdotdev/issue/APP-5522/fix-report-error-demotions-of-typed-errors-into-extra-and-related-form) ## What a reviewer would now do differently on PR #13483's diff Before: the reviewer read "review it against `.agents/skills/logging-and-error-reporting/SKILL.md`" as one bullet among a dozen others, with no requirement to look at every call site individually — easy to satisfy with a spot-check on a mega-diff. After: a dedicated `## Pre-Verdict Audit: error-reporting form` section (mirroring the core skill's Comments/Tests audit, added in the companion PR) makes it mandatory, before drafting the body or verdict, to list every `report_error!`/`report_if_error!` call the diff adds or changes, one by one with file:line, and check each against the four named forbidden forms. That per-line enumeration — not a narrative pass — is what would have surfaced the `extra: { "error" => %error }` demotion at `runtime/mod.rs:813`/`:709` before merge. ## Testing Docs-only change (`.agents/skills/review-pr-local/SKILL.md`). No Rust code changed, so `cargo clippy` doesn't apply; `./script/format` was run and made no additional changes. - [x] I have manually tested my changes locally with `./script/run` — N/A, no runtime behavior; this only changes a skill markdown file read by the review agent. ### Screenshots / Videos N/A — not a UI change. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode <!-- warp:pr-description-artifacts start --> <!-- warp:pr-description-artifacts end --> Co-authored-by: warp-agent-staging[bot] <240773466+warp-agent-staging[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the review-prompting gap from APP-5522: the core
review-prskill's Pre-Verdict Audit had a mandatory, mechanical checklist for Comments and Tests, but nothing for error-reporting form. That gap is why warp's PR #13483 (a 345-file, ~974-linelog::error!→report_error!migration) merged with zero form findings, even though the migration itself introduced.agents/skills/logging-and-error-reporting/SKILL.md, which forbids the exact form it used at several call sites (a typed error demoted intoextra:).Companion PR (repo-specific substance for warp): warpdotdev/warp#15296
Changes
error-reporting-formas an overridable category in the "Repository-specific guidance" section, alongsidecommentingandtesting, so a repo companion skill (e.g. warp'sreview-pr-local) is authorized to supply the repo-specific rules.What a reviewer would now do differently on PR #13483's diff
Today,
review-pr's Pre-Verdict Audit forces a per-line enumeration only for comments and tests, so a reviewer can complete the mandatory audit on a mega-diff without ever individually inspecting areport_error!call — the existing warp-side guidance was a narrative bullet, easy to skim past on 345 changed files. With this change, the audit itself requires listing everyreport_error!/report_if_error!line the diff adds and checking it individually (paired with the warp-side companion PR, which supplies the exact forbidden forms). That mechanical, per-line requirement — not a better prose reminder — is what would have caughtcrates/warpui_core/src/runtime/mod.rs:813and:709before merge.Verification
Docs-only change (a skill markdown file). No build/tests apply; verified the diff is scoped to
.agents/skills/review-pr/SKILL.mdand re-read the file end to end to confirm the new audit bullet and the updated "overridable categories" sentence stay consistent with the rest of the skill's contract (output schema, severity labels, safety/evidence rules, and the suggestion-block/diff-annotation contract are all unchanged).