NODE-2329 Reestabilish input stream on unexpected read bytes size#3704
Open
xrtm000 wants to merge 4 commits intoversion-1.4.xfrom
Open
NODE-2329 Reestabilish input stream on unexpected read bytes size#3704xrtm000 wants to merge 4 commits intoversion-1.4.xfrom
xrtm000 wants to merge 4 commits intoversion-1.4.xfrom
Conversation
yvaskov
approved these changes
May 23, 2022
ivan-mashonskiy
approved these changes
May 27, 2022
yvaskov
approved these changes
May 31, 2022
vsuharnikov
approved these changes
Nov 13, 2023
| log.info(s"$factReadSize != expected $blockSize") | ||
| log.info(s"reestablishing input stream") | ||
| inputStream.close() | ||
| inputStream = getInputStream() |
Contributor
There was a problem hiding this comment.
Just a notice: actually we have blockSize for each block, so we don't need to read whole BlockInfoAtHeight sequence to find the offset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.